[cfe-commits] [libcxx] r120458 - in /libcxx/trunk: include/ src/ test/thread/futures/futures.atomic_future/ test/thread/futures/futures.tas/futures.task.members/ test/thread/futures/futures.tas/futures.task.nonmembers/ test/thread/futures/futures.unique_future/

Howard Hinnant hhinnant at apple.com
Tue Nov 30 12:23:32 PST 2010


Author: hhinnant
Date: Tue Nov 30 14:23:32 2010
New Revision: 120458

URL: http://llvm.org/viewvc/llvm-project?rev=120458&view=rev
Log:
Implemented N3194

Added:
    libcxx/trunk/test/thread/futures/futures.unique_future/share.pass.cpp
Removed:
    libcxx/trunk/test/thread/futures/futures.atomic_future/
Modified:
    libcxx/trunk/include/future
    libcxx/trunk/src/future.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_copy.fail.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_move.pass.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_copy.fail.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_default.pass.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func.pass.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func_alloc.pass.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_move.pass.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/swap.pass.cpp
    libcxx/trunk/test/thread/futures/futures.tas/futures.task.nonmembers/swap.pass.cpp

Modified: libcxx/trunk/include/future
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/future?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/include/future (original)
+++ libcxx/trunk/include/future Tue Nov 30 14:23:32 2010
@@ -156,6 +156,7 @@
     ~future();
     future& operator=(const future& rhs) = delete;
     future& operator=(future&&);
+    shared_future<R> share() &&;
 
     // retrieving the value
     R get();
@@ -182,6 +183,7 @@
     ~future();
     future& operator=(const future& rhs) = delete;
     future& operator=(future&&);
+    shared_future<R&> share() &&;
 
     // retrieving the value
     R& get();
@@ -208,6 +210,7 @@
     ~future();
     future& operator=(const future& rhs) = delete;
     future& operator=(future&&);
+    shared_future<void> share() &&;
 
     // retrieving the value
     void get();
@@ -305,81 +308,6 @@
         wait_until(const chrono::time_point<Clock, Duration>& abs_time) const;
 };
 
-template <class R>
-class atomic_future
-{
-public:
-    atomic_future();
-    atomic_future(const atomic_future& rhs);
-    atomic_future(future<R>&&);
-    ~atomic_future();
-    atomic_future& operator=(const atomic_future& rhs);
-
-    // retrieving the value
-    const R& get() const;
-
-    // functions to check state
-    bool valid() const;
-
-    void wait() const;
-    template <class Rep, class Period>
-        future_status
-        wait_for(const chrono::duration<Rep, Period>& rel_time) const;
-    template <class Clock, class Duration>
-        future_status
-        wait_until(const chrono::time_point<Clock, Duration>& abs_time) const;
-};
-
-template <class R>
-class atomic_future<R&>
-{
-public:
-    atomic_future();
-    atomic_future(const atomic_future& rhs);
-    atomic_future(future<R>&&);
-    ~atomic_future();
-    atomic_future& operator=(const atomic_future& rhs);
-
-    // retrieving the value
-    R& get() const;
-
-    // functions to check state
-    bool valid() const;
-
-    void wait() const;
-    template <class Rep, class Period>
-        future_status
-        wait_for(const chrono::duration<Rep, Period>& rel_time) const;
-    template <class Clock, class Duration>
-        future_status
-        wait_until(const chrono::time_point<Clock, Duration>& abs_time) const;
-};
-
-template <>
-class atomic_future<void>
-{
-public:
-    atomic_future();
-    atomic_future(const atomic_future& rhs);
-    atomic_future(future<R>&&);
-    ~atomic_future();
-    atomic_future& operator=(const atomic_future& rhs);
-
-    // retrieving the value
-    void get() const;
-
-    // functions to check state
-    bool valid() const;
-
-    void wait() const;
-    template <class Rep, class Period>
-        future_status
-        wait_for(const chrono::duration<Rep, Period>& rel_time) const;
-    template <class Clock, class Duration>
-        future_status
-        wait_until(const chrono::time_point<Clock, Duration>& abs_time) const;
-};
-
 template <class F, class... Args>
   future<typename result_of<F(Args...)>::type>
   async(F&& f, Args&&... args);
@@ -413,7 +341,7 @@
     packaged_task& operator=(packaged_task&& other);
     void swap(packaged_task& other);
 
-    explicit operator bool() const;
+    bool valid() const;
 
     // result retrieval
     future<R> get_future();
@@ -986,6 +914,7 @@
 public:
 #endif  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
     ~future();
+    shared_future<_R> share();
 
     // retrieving the value
     _R get();
@@ -1083,6 +1012,7 @@
 public:
 #endif  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
     ~future();
+    shared_future<_R&> share();
 
     // retrieving the value
     _R& get();
@@ -1175,6 +1105,7 @@
 public:
 #endif  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
     ~future();
+    shared_future<void> share();
 
     // retrieving the value
     void get();
@@ -1893,8 +1824,7 @@
     }
 
     _LIBCPP_INLINE_VISIBILITY
-    //explicit
-        operator bool() const {return __p_.__state_ != nullptr;}
+    bool valid() const {return __p_.__state_ != nullptr;}
 
     // result retrieval
     _LIBCPP_INLINE_VISIBILITY
@@ -1956,7 +1886,7 @@
 packaged_task<_R(_ArgTypes...)>::reset()
 {
 #ifndef _LIBCPP_NO_EXCEPTIONS
-    if (!(*this))
+    if (!valid())
         throw future_error(make_error_code(future_errc::no_state));
 #endif  // _LIBCPP_NO_EXCEPTIONS
     __p_ = promise<result_type>();
@@ -2009,8 +1939,7 @@
     }
 
     _LIBCPP_INLINE_VISIBILITY
-    //explicit
-        operator bool() const {return __p_.__state_ != nullptr;}
+    bool valid() const {return __p_.__state_ != nullptr;}
 
     // result retrieval
     _LIBCPP_INLINE_VISIBILITY
@@ -2074,7 +2003,7 @@
 packaged_task<void(_ArgTypes...)>::reset()
 {
 #ifndef _LIBCPP_NO_EXCEPTIONS
-    if (!(*this))
+    if (!valid())
         throw future_error(make_error_code(future_errc::no_state));
 #endif  // _LIBCPP_NO_EXCEPTIONS
     __p_ = promise<result_type>();
@@ -2352,222 +2281,27 @@
     __x.swap(__y);
 }
 
-// atomic_future
-
-template <class _R>
-class _LIBCPP_VISIBLE atomic_future
-{
-    __assoc_state<_R>* __state_;
-    mutable mutex __mut_;
-
-public:
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future() : __state_(nullptr) {}
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future(const atomic_future& __rhs) : __state_(__rhs.__state_)
-        {if (__state_) __state_->__add_shared();}
-#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future(future<_R>&& __f) : __state_(__f.__state_)
-        {__f.__state_ = nullptr;}
-#endif  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
-    ~atomic_future();
-    atomic_future& operator=(const atomic_future& __rhs);
-
-    // retrieving the value
-    _LIBCPP_INLINE_VISIBILITY
-    const _R& get() const {return __state_->copy();}
-
-    void swap(atomic_future& __rhs);
-
-    // functions to check state
-    _LIBCPP_INLINE_VISIBILITY
-    bool valid() const {return __state_ != nullptr;}
-
-    _LIBCPP_INLINE_VISIBILITY
-    void wait() const {__state_->wait();}
-    template <class _Rep, class _Period>
-        _LIBCPP_INLINE_VISIBILITY
-        future_status
-        wait_for(const chrono::duration<_Rep, _Period>& __rel_time) const
-            {return __state_->wait_for(__rel_time);}
-    template <class _Clock, class _Duration>
-        _LIBCPP_INLINE_VISIBILITY
-        future_status
-        wait_until(const chrono::time_point<_Clock, _Duration>& __abs_time) const
-            {return __state_->wait_until(__abs_time);}
-};
-
-template <class _R>
-atomic_future<_R>::~atomic_future()
-{
-    if (__state_)
-        __state_->__release_shared();
-}
-
 template <class _R>
-atomic_future<_R>&
-atomic_future<_R>::operator=(const atomic_future& __rhs)
-{
-    if (this != &__rhs)
-    {
-        unique_lock<mutex> __this(__mut_, defer_lock);
-        unique_lock<mutex> __that(__rhs.__mut_, defer_lock);
-        _STD::lock(__this, __that);
-        if (__rhs.__state_)
-            __rhs.__state_->__add_shared();
-        if (__state_)
-            __state_->__release_shared();
-        __state_ = __rhs.__state_;
-    }
-    return *this;
-}
-
-template <class _R>
-void
-atomic_future<_R>::swap(atomic_future& __rhs)
-{
-    if (this != &__rhs)
-    {
-        unique_lock<mutex> __this(__mut_, defer_lock);
-        unique_lock<mutex> __that(__rhs.__mut_, defer_lock);
-        _STD::lock(__this, __that);
-        _STD::swap(__state_, __rhs.__state_);
-    }
-}
-
-template <class _R>
-class _LIBCPP_VISIBLE atomic_future<_R&>
-{
-    __assoc_state<_R&>* __state_;
-    mutable mutex __mut_;
-
-public:
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future() : __state_(nullptr) {}
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future(const atomic_future& __rhs) : __state_(__rhs.__state_)
-        {if (__state_) __state_->__add_shared();}
-#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future(future<_R&>&& __f) : __state_(__f.__state_)
-        {__f.__state_ = nullptr;}
-#endif  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
-    ~atomic_future();
-    atomic_future& operator=(const atomic_future& __rhs);
-
-    // retrieving the value
-    _LIBCPP_INLINE_VISIBILITY
-    _R& get() const {return __state_->copy();}
-
-    void swap(atomic_future& __rhs);
-
-    // functions to check state
-    _LIBCPP_INLINE_VISIBILITY
-    bool valid() const {return __state_ != nullptr;}
-
-    _LIBCPP_INLINE_VISIBILITY
-    void wait() const {__state_->wait();}
-    template <class _Rep, class _Period>
-        _LIBCPP_INLINE_VISIBILITY
-        future_status
-        wait_for(const chrono::duration<_Rep, _Period>& __rel_time) const
-            {return __state_->wait_for(__rel_time);}
-    template <class _Clock, class _Duration>
-        _LIBCPP_INLINE_VISIBILITY
-        future_status
-        wait_until(const chrono::time_point<_Clock, _Duration>& __abs_time) const
-            {return __state_->wait_until(__abs_time);}
-};
-
-template <class _R>
-atomic_future<_R&>::~atomic_future()
-{
-    if (__state_)
-        __state_->__release_shared();
-}
-
-template <class _R>
-atomic_future<_R&>&
-atomic_future<_R&>::operator=(const atomic_future& __rhs)
+inline _LIBCPP_INLINE_VISIBILITY
+shared_future<_R>
+future<_R>::share()
 {
-    if (this != &__rhs)
-    {
-        unique_lock<mutex> __this(__mut_, defer_lock);
-        unique_lock<mutex> __that(__rhs.__mut_, defer_lock);
-        _STD::lock(__this, __that);
-        if (__rhs.__state_)
-            __rhs.__state_->__add_shared();
-        if (__state_)
-            __state_->__release_shared();
-        __state_ = __rhs.__state_;
-    }
-    return *this;
+    return shared_future<_R>(_STD::move(*this));
 }
 
 template <class _R>
-void
-atomic_future<_R&>::swap(atomic_future& __rhs)
+inline _LIBCPP_INLINE_VISIBILITY
+shared_future<_R&>
+future<_R&>::share()
 {
-    if (this != &__rhs)
-    {
-        unique_lock<mutex> __this(__mut_, defer_lock);
-        unique_lock<mutex> __that(__rhs.__mut_, defer_lock);
-        _STD::lock(__this, __that);
-        _STD::swap(__state_, __rhs.__state_);
-    }
+    return shared_future<_R&>(_STD::move(*this));
 }
 
-template <>
-class _LIBCPP_VISIBLE atomic_future<void>
-{
-    __assoc_sub_state* __state_;
-    mutable mutex __mut_;
-
-public:
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future() : __state_(nullptr) {}
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future(const atomic_future& __rhs) : __state_(__rhs.__state_)
-        {if (__state_) __state_->__add_shared();}
-#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
-    _LIBCPP_INLINE_VISIBILITY
-    atomic_future(future<void>&& __f) : __state_(__f.__state_)
-        {__f.__state_ = nullptr;}
-#endif  // _LIBCPP_HAS_NO_RVALUE_REFERENCES
-    ~atomic_future();
-    atomic_future& operator=(const atomic_future& __rhs);
-
-    // retrieving the value
-    _LIBCPP_INLINE_VISIBILITY
-    void get() const {__state_->copy();}
-
-    void swap(atomic_future& __rhs);
-
-    // functions to check state
-    _LIBCPP_INLINE_VISIBILITY
-    bool valid() const {return __state_ != nullptr;}
-
-    _LIBCPP_INLINE_VISIBILITY
-    void wait() const {__state_->wait();}
-    template <class _Rep, class _Period>
-        _LIBCPP_INLINE_VISIBILITY
-        future_status
-        wait_for(const chrono::duration<_Rep, _Period>& __rel_time) const
-            {return __state_->wait_for(__rel_time);}
-    template <class _Clock, class _Duration>
-        _LIBCPP_INLINE_VISIBILITY
-        future_status
-        wait_until(const chrono::time_point<_Clock, _Duration>& __abs_time) const
-            {return __state_->wait_until(__abs_time);}
-};
-
-template <class _R>
 inline _LIBCPP_INLINE_VISIBILITY
-void
-swap(atomic_future<_R>& __x, atomic_future<_R>& __y)
+shared_future<void>
+future<void>::share()
 {
-    __x.swap(__y);
+    return shared_future<void>(_STD::move(*this));
 }
 
 _LIBCPP_END_NAMESPACE_STD

Modified: libcxx/trunk/src/future.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/future.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/src/future.cpp (original)
+++ libcxx/trunk/src/future.cpp Tue Nov 30 14:23:32 2010
@@ -256,39 +256,4 @@
     return *this;
 }
 
-atomic_future<void>::~atomic_future()
-{
-    if (__state_)
-        __state_->__release_shared();
-}
-
-atomic_future<void>&
-atomic_future<void>::operator=(const atomic_future& __rhs)
-{
-    if (this != &__rhs)
-    {
-        unique_lock<mutex> __this(__mut_, defer_lock);
-        unique_lock<mutex> __that(__rhs.__mut_, defer_lock);
-        _STD::lock(__this, __that);
-        if (__rhs.__state_)
-            __rhs.__state_->__add_shared();
-        if (__state_)
-            __state_->__release_shared();
-        __state_ = __rhs.__state_;
-    }
-    return *this;
-}
-
-void
-atomic_future<void>::swap(atomic_future& __rhs)
-{
-    if (this != &__rhs)
-    {
-        unique_lock<mutex> __this(__mut_, defer_lock);
-        unique_lock<mutex> __that(__rhs.__mut_, defer_lock);
-        _STD::lock(__this, __that);
-        _STD::swap(__state_, __rhs.__state_);
-    }
-}
-
 _LIBCPP_END_NAMESPACE_STD

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_copy.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_copy.fail.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_copy.fail.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_copy.fail.cpp Tue Nov 30 14:23:32 2010
@@ -32,8 +32,8 @@
         std::packaged_task<double(int, char)> p0(A(5));
         std::packaged_task<double(int, char)> p;
         p = p0;
-        assert(!p0);
-        assert(p);
+        assert(!p0.valid());
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -42,7 +42,7 @@
         std::packaged_task<double(int, char)> p0;
         std::packaged_task<double(int, char)> p;
         p = p0;
-        assert(!p0);
-        assert(!p);
+        assert(!p0.valid());
+        assert(!p.valid());
     }
 }

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_move.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_move.pass.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_move.pass.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/assign_move.pass.cpp Tue Nov 30 14:23:32 2010
@@ -32,8 +32,8 @@
         std::packaged_task<double(int, char)> p0(A(5));
         std::packaged_task<double(int, char)> p;
         p = std::move(p0);
-        assert(!p0);
-        assert(p);
+        assert(!p0.valid());
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -42,7 +42,7 @@
         std::packaged_task<double(int, char)> p0;
         std::packaged_task<double(int, char)> p;
         p = std::move(p0);
-        assert(!p0);
-        assert(!p);
+        assert(!p0.valid());
+        assert(!p.valid());
     }
 }

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_copy.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_copy.fail.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_copy.fail.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_copy.fail.cpp Tue Nov 30 14:23:32 2010
@@ -31,8 +31,8 @@
     {
         std::packaged_task<double(int, char)> p0(A(5));
         std::packaged_task<double(int, char)> p(p0);
-        assert(!p0);
-        assert(p);
+        assert(!p0.valid());
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -40,7 +40,7 @@
     {
         std::packaged_task<double(int, char)> p0;
         std::packaged_task<double(int, char)> p(p0);
-        assert(!p0);
-        assert(!p);
+        assert(!p0.valid());
+        assert(!p.valid());
     }
 }

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_default.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_default.pass.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_default.pass.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_default.pass.cpp Tue Nov 30 14:23:32 2010
@@ -21,5 +21,5 @@
 int main()
 {
     std::packaged_task<A(int, char)> p;
-    assert(!p);
+    assert(!p.valid());
 }

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func.pass.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func.pass.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func.pass.cpp Tue Nov 30 14:23:32 2010
@@ -39,7 +39,7 @@
 {
     {
         std::packaged_task<double(int, char)> p(A(5));
-        assert(p);
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -51,7 +51,7 @@
     {
         A a(5);
         std::packaged_task<double(int, char)> p(a);
-        assert(p);
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func_alloc.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func_alloc.pass.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func_alloc.pass.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_func_alloc.pass.cpp Tue Nov 30 14:23:32 2010
@@ -43,7 +43,7 @@
         std::packaged_task<double(int, char)> p(std::allocator_arg,
                                                 test_allocator<A>(), A(5));
         assert(test_alloc_base::count > 0);
-        assert(p);
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -58,7 +58,7 @@
         std::packaged_task<double(int, char)> p(std::allocator_arg,
                                                 test_allocator<A>(), a);
         assert(test_alloc_base::count > 0);
-        assert(p);
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_move.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_move.pass.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_move.pass.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/ctor_move.pass.cpp Tue Nov 30 14:23:32 2010
@@ -31,8 +31,8 @@
     {
         std::packaged_task<double(int, char)> p0(A(5));
         std::packaged_task<double(int, char)> p = std::move(p0);
-        assert(!p0);
-        assert(p);
+        assert(!p0.valid());
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -40,7 +40,7 @@
     {
         std::packaged_task<double(int, char)> p0;
         std::packaged_task<double(int, char)> p = std::move(p0);
-        assert(!p0);
-        assert(!p);
+        assert(!p0.valid());
+        assert(!p.valid());
     }
 }

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/swap.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/swap.pass.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/swap.pass.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.members/swap.pass.cpp Tue Nov 30 14:23:32 2010
@@ -32,8 +32,8 @@
         std::packaged_task<double(int, char)> p0(A(5));
         std::packaged_task<double(int, char)> p;
         p.swap(p0);
-        assert(!p0);
-        assert(p);
+        assert(!p0.valid());
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -42,7 +42,7 @@
         std::packaged_task<double(int, char)> p0;
         std::packaged_task<double(int, char)> p;
         p.swap(p0);
-        assert(!p0);
-        assert(!p);
+        assert(!p0.valid());
+        assert(!p.valid());
     }
 }

Modified: libcxx/trunk/test/thread/futures/futures.tas/futures.task.nonmembers/swap.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.tas/futures.task.nonmembers/swap.pass.cpp?rev=120458&r1=120457&r2=120458&view=diff
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.tas/futures.task.nonmembers/swap.pass.cpp (original)
+++ libcxx/trunk/test/thread/futures/futures.tas/futures.task.nonmembers/swap.pass.cpp Tue Nov 30 14:23:32 2010
@@ -34,8 +34,8 @@
         std::packaged_task<double(int, char)> p0(A(5));
         std::packaged_task<double(int, char)> p;
         swap(p, p0);
-        assert(!p0);
-        assert(p);
+        assert(!p0.valid());
+        assert(p.valid());
         std::future<double> f = p.get_future();
         p(3, 'a');
         assert(f.get() == 105.0);
@@ -44,7 +44,7 @@
         std::packaged_task<double(int, char)> p0;
         std::packaged_task<double(int, char)> p;
         swap(p, p0);
-        assert(!p0);
-        assert(!p);
+        assert(!p0.valid());
+        assert(!p.valid());
     }
 }

Added: libcxx/trunk/test/thread/futures/futures.unique_future/share.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/futures/futures.unique_future/share.pass.cpp?rev=120458&view=auto
==============================================================================
--- libcxx/trunk/test/thread/futures/futures.unique_future/share.pass.cpp (added)
+++ libcxx/trunk/test/thread/futures/futures.unique_future/share.pass.cpp Tue Nov 30 14:23:32 2010
@@ -0,0 +1,66 @@
+//===----------------------------------------------------------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+// <future>
+
+// class future<R>
+
+// shared_future<R> share() &&;
+
+#include <future>
+#include <cassert>
+
+int main()
+{
+    {
+        typedef int T;
+        std::promise<T> p;
+        std::future<T> f0 = p.get_future();
+        std::shared_future<T> f = std::move(f0.share());
+        assert(!f0.valid());
+        assert(f.valid());
+    }
+    {
+        typedef int T;
+        std::future<T> f0;
+        std::shared_future<T> f = std::move(f0.share());
+        assert(!f0.valid());
+        assert(!f.valid());
+    }
+    {
+        typedef int& T;
+        std::promise<T> p;
+        std::future<T> f0 = p.get_future();
+        std::shared_future<T> f = std::move(f0.share());
+        assert(!f0.valid());
+        assert(f.valid());
+    }
+    {
+        typedef int& T;
+        std::future<T> f0;
+        std::shared_future<T> f = std::move(f0.share());
+        assert(!f0.valid());
+        assert(!f.valid());
+    }
+    {
+        typedef void T;
+        std::promise<T> p;
+        std::future<T> f0 = p.get_future();
+        std::shared_future<T> f = std::move(f0.share());
+        assert(!f0.valid());
+        assert(f.valid());
+    }
+    {
+        typedef void T;
+        std::future<T> f0;
+        std::shared_future<T> f = std::move(f0.share());
+        assert(!f0.valid());
+        assert(!f.valid());
+    }
+}





More information about the cfe-commits mailing list