[cfe-commits] r120429 - in /cfe/trunk: clang.xcodeproj/project.pbxproj include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h lib/Basic/Builtins.cpp lib/Basic/Targets.cpp lib/Frontend/FrontendAction.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaLookup.cpp

[Chris Lattner]

On Nov 30, 2010, at 9:35 AM, Fariborz Jahanian wrote:

> Author: fjahanian
> Date: Tue Nov 30 11:35:24 2010
> New Revision: 120429
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=120429&view=rev
> Log:
> Such function decls,as objc's objc_msgSend, builtins in 
> a specific language. We are adding such language info. by
> extensing Builtins.def and via a language flag added
> to LIBBUILTIN/BUILTIN and check for that when deciding
> a name is builtin or not. Implements //rdar://8689273.

Makes sense to me!  One minor request:

> +  enum LANGUAGEID {
> +    C_LANG = 0x1,     // builtin for c only.
> +    CXX_LANG = 0x2,   // builtin for cplusplus only.
> +    OBJC_LANG = 0x4,  // builtin for objective-c and objective-c++
> +    ALL_LANGUAGES = (C_LANG|CXX_LANG|OBJC_LANG) //builtin is for all languages.
> +  };

Please rename LANGUAGEID to LanguageID, since it is not itself an enumerator.

Thanks Fariborz!

-Chris