[cfe-commits] r120389 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/SemaCXX/friend.cpp

Nico Weber nicolasweber at gmx.de
Mon Nov 29 20:44:33 PST 2010


Author: nico
Date: Mon Nov 29 22:44:33 2010
New Revision: 120389

URL: http://llvm.org/viewvc/llvm-project?rev=120389&view=rev
Log:
Fix bug in r120299 spotted by dgregor.

Modified:
    cfe/trunk/lib/Sema/SemaExpr.cpp
    cfe/trunk/test/SemaCXX/friend.cpp

Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=120389&r1=120388&r2=120389&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Mon Nov 29 22:44:33 2010
@@ -3843,10 +3843,10 @@
                                         ParmVarDecl *Param) {
   if (Param->hasUnparsedDefaultArg()) {
     Diag(CallLoc,
-          diag::err_use_of_default_argument_to_function_declared_later) <<
+         diag::err_use_of_default_argument_to_function_declared_later) <<
       FD << cast<CXXRecordDecl>(FD->getDeclContext())->getDeclName();
     Diag(UnparsedDefaultArgLocs[Param],
-          diag::note_default_argument_declared_here);
+         diag::note_default_argument_declared_here);
     return ExprError();
   }
   
@@ -3868,7 +3868,7 @@
       //   The names in the [default argument] expression are bound, and
       //   the semantic constraints are checked, at the point where the
       //   default argument expression appears.
-      ContextRAII SavedContext(*this, FD->getDeclContext());
+      ContextRAII SavedContext(*this, FD);
       Result = SubstExpr(UninstExpr, ArgList);
     }
     if (Result.isInvalid())

Modified: cfe/trunk/test/SemaCXX/friend.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/friend.cpp?rev=120389&r1=120388&r2=120389&view=diff
==============================================================================
--- cfe/trunk/test/SemaCXX/friend.cpp (original)
+++ cfe/trunk/test/SemaCXX/friend.cpp Mon Nov 29 22:44:33 2010
@@ -112,3 +112,21 @@
     vector<A> v(1);
   }
 }
+namespace test6_3 {
+  template<class T>
+  class vector {
+   public:
+    vector(int i) {}
+    void f(const T& t = T()) {}
+  };
+  class A {
+   public:
+   private:
+    friend void vector<A>::f(const A&);
+    A() {}
+  };
+  void f() {
+    vector<A> v(1);
+    v.f();
+  }
+}





More information about the cfe-commits mailing list