[cfe-commits] r120376 - /cfe/trunk/lib/AST/Type.cpp

[John McCall]

On Nov 29, 2010, at 5:28 PM, Nick Lewycky wrote:

> Author: nicholas
> Date: Mon Nov 29 19:28:32 2010
> New Revision: 120376
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=120376&view=rev
> Log:
> Add a default clause to avoid this GCC warning:
> Type.cpp:1000: warning: control reaches end of non-void function

You and dgregor are fighting about this very slowly. :)

Please use llvm_unreachable and a return 0 instead of adding a default case to a supposedly exhaustive switch.

John.