[cfe-commits] r120088 - in /cfe/trunk: include/clang/AST/DeclBase.h include/clang/Driver/CC1Options.td include/clang/Frontend/ASTConsumers.h include/clang/Frontend/FrontendActions.h include/clang/Frontend/FrontendOptions.h lib/AST/CMakeLists.txt

[Chandler Carruth]

On Sun, Nov 28, 2010 at 4:56 PM, John McCall <rjmccall at apple.com> wrote:

>
> On Nov 28, 2010, at 10:19 AM, Chris Lattner wrote:
>
> >
> > On Nov 24, 2010, at 3:21 AM, John McCall wrote:
> >
> >> Author: rjmccall
> >> Date: Wed Nov 24 05:21:45 2010
> >> New Revision: 120088
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=120088&view=rev
> >> Log:
> >> Add -cc1 -ast-dump-xml, an excessively detailed XML dump of the
> internals
> >> of the ASTs.  Only available in assertions builds.  No stability
> guarantee.
> >>
> >> This is intended solely as a debugging tool.  I'm not sure if the goals
> >> are sufficiently aligned with the XML printer to allow a common
> >> implementation.
> >>
> >> Currently just falls back on the StmtDumper to display statements,
> >> which means it doesn't produce valid XML in those cases.
> >
> > I'm a bit dubious about this given the struggles we've had with the
> current XML dumper.  Please document somewhere that the output isn't
> guaranteed to be stable.
>
> Can you elaborate on those struggles?  It seems to mostly be unmaintained.
>
> I would like this to eventually replace -dump-ast, if we can agree on a
> syntax;  -dump-ast is nice for expressions, but useless for declarations.


Craig and Zhanyong have an analogous dump output built around
RecursiveASTVisitor. Its output is also structured in a form to make it easy
to write FileCheck-based tests for IIRC. I believe they were intending to
commit that, but had held off thinking the existing system was "Good
Enough". If they can contribute this, would that be a good place to focus
effort on this front? I think it is already more complete than this dumper,
although I've not audited it by any means.


>


> I am not wedded to XML, but there are much better visualization /
> exploration tools for XML than for not-really s-exprs. :)
>
> >  Also, why only in assert builds?  We have no precedent for that.
>
> Since it's just a debugging tool, I didn't want to pay for the code size in
> release.  If you tell me not to sweat it, I won't. :)
>
> John.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101128/a28bab9b/attachment.html>