[cfe-commits] r119939 - /cfe/trunk/lib/Basic/FileManager.cpp

[Benjamin Kramer]

Author: d0k
Date: Sun Nov 21 05:32:22 2010
New Revision: 119939

URL: http://llvm.org/viewvc/llvm-project?rev=119939&view=rev
Log:
Filename.rfind("/\\") won't give us the position of the last directory seperator.

Modified:
    cfe/trunk/lib/Basic/FileManager.cpp

Modified: cfe/trunk/lib/Basic/FileManager.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/FileManager.cpp?rev=119939&r1=119938&r2=119939&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/FileManager.cpp (original)
+++ cfe/trunk/lib/Basic/FileManager.cpp Sun Nov 21 05:32:22 2010
@@ -47,7 +47,7 @@
 
 #ifdef LLVM_ON_WIN32
 
-#define DIR_SEPARATOR_CHARS "/\\"
+#define IS_DIR_SEPARATOR_CHAR(x) ((x) == '/' || (x) == '\\')
 
 namespace {
   static std::string GetFullPath(const char *relPath) {
@@ -104,7 +104,7 @@
 
 #else
 
-#define DIR_SEPARATOR_CHARS "/"
+#define IS_DIR_SEPARATOR_CHAR(x) ((x) == '/')
 
 class FileManager::UniqueDirContainer {
   /// UniqueDirs - Cache from ID's to existing directories/files.
@@ -203,20 +203,21 @@
   // Figure out what directory it is in.   If the string contains a / in it,
   // strip off everything after it.
   // FIXME: this logic should be in sys::Path.
-  size_t SlashPos = Filename.rfind(DIR_SEPARATOR_CHARS);
-  
+  size_t SlashPos = Filename.size();
+  while (SlashPos != 0 && !IS_DIR_SEPARATOR_CHAR(Filename[SlashPos-1]))
+    --SlashPos;
+
   // Use the current directory if file has no path component.
-  if (SlashPos == llvm::StringRef::npos)
+  if (SlashPos == 0)
     return FileMgr.getDirectory(".", FileSystemOpts);
 
   if (SlashPos == Filename.size()-1)
     return 0;       // If filename ends with a /, it's a directory.
-  
+
   // Ignore repeated //'s.
-  while (SlashPos != 0 &&
-         llvm::StringRef(DIR_SEPARATOR_CHARS).count(Filename[SlashPos-1]))
+  while (SlashPos != 0 && IS_DIR_SEPARATOR_CHAR(Filename[SlashPos-1]))
     --SlashPos;
-  
+
   return FileMgr.getDirectory(Filename.substr(0, SlashPos), FileSystemOpts);
 }
 
@@ -226,8 +227,7 @@
 const DirectoryEntry *FileManager::getDirectory(llvm::StringRef Filename,
                                       const FileSystemOptions &FileSystemOpts) {
   // stat doesn't like trailing separators (at least on Windows).
-  if (Filename.size() > 1 &&
-      (Filename.back() == '/' || Filename.back() == '\\'))
+  if (Filename.size() > 1 && IS_DIR_SEPARATOR_CHAR(Filename.back()))
     Filename = Filename.substr(0, Filename.size()-1);
 
   ++NumDirLookups;