[cfe-commits] [libcxx] r119611 - /libcxx/trunk/include/algorithm

[Chris Lattner]

On Nov 18, 2010, at 11:53 PM, Chandler Carruth wrote:

> On Thu, Nov 18, 2010 at 8:18 AM, Howard Hinnant <hhinnant at apple.com> wrote:
> Ok, if that is the consensus of the community I can easily remove them.  On a previous product this was a customer-requested feature and subsequent feedback on it was positive.
> 
> I encourage people to view this question through actual use of the header, as opposed to a svn diff.
> 
> I'm actually pretty positive on them, but I wonder if using the (somewhat more annoying to maintain) '//' prefix comments would help avoid confusion? That would provide an ever-present reminder, even in diffs, that this is merely a comment. On the other side, it makes formatting etc more annoying so I understand that it may not be the right tradeoff.

I agree that it would make it easier to read/know.  On the other hand, /* */ comments have a nice vectorized comment skipper and // don't (and can't reasonably).  It probably isn't measurable, but this means that // comments are slower to lex than /* comments :-)

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101120/ec8c67c4/attachment.html>