[cfe-commits] [PATCH] Prior to fixing bug7505, some minor refactorings: const-correctness, extract method, convert function to method

[Faisal Vali]

While working on completing my long overdue patch  (Sorry Doug ;) for
bug 7505 [http://llvm.org/bugs/show_bug.cgi?id=7505]
I've felt the need to slightly refactor the code.

Thus, this is an interim patch (does not fix 7505) and should not
change the semantics of the existing code.

It includes the following refactorings:
 1) Moved NoteAllOverloadCandidates into Sema, next to NoteOverloadCandidate
 2) Made OverloadExpr::find const correct
 3) Extracted a function 'GetFunctionTypeSansPtrOrRef' out of the
quite lengthy ResolveAddressOfOverloadedFunction
   (I anticipate extracting a few more inline functions, please let
me know if there is some philosophical or practical
     reason not to continue to do so :)

I tested it against Sema/, SemaCXX/, CXX/.

Thanks in advance for any feedback!

Faisal Vali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: const-correctness-for-find-overload-expression.patch
Type: application/octet-stream
Size: 17437 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101120/6238d047/attachment.obj>