[cfe-commits] [libcxx] r119611 - /libcxx/trunk/include/algorithm

[Chris Lattner]

On Nov 18, 2010, at 8:18 AM, Howard Hinnant wrote:

>>>> Should this constructor also be protected by the rvalue references macro?
>>> 
>>> No, but only because it is a comment. :-)
>>> 
>>> Each public header begins with a synopsis in comments at the top, which is what we're looking at here.
>> 
>> 
>> I find that synopsis super-confusing, by the way ;)
>> 
>> 	- Doug
> 
> Ok, if that is the consensus of the community I can easily remove them.  On a previous product this was a customer-requested feature and subsequent feedback on it was positive.
> 
> I encourage people to view this question through actual use of the header, as opposed to a svn diff.

I found it really confusing the first few times I read the diff and looked at the source file.  Now that I know that they are there, I find it really helpful.

<aside>One specific personal issue I always have is that I cannot remember whether map/set insert return true for "insert succeeded" or true for conflict detected.  I don't know why I can't remember this, but I always have to look it up whenever I call one of these methods and I care about the result.

-Chris