[cfe-commits] r119480 - /cfe/trunk/lib/Checker/GRCXXExprEngine.cpp

[Marcin Świderski]

2010/11/17 Ted Kremenek <kremenek at apple.com>

> Why remove this?  This is meant for use by checkers that want to check a
> post-condition on a function/method call.
>
> As I understand this is for inlined call case. Shouldn't checking the
post-condition be performed after processing inilned call? From empirical
testing I can tell that this is not happening though.


> On Nov 16, 2010, at 11:31 PM, Zhongxing Xu wrote:
>
> > Author: zhongxingxu
> > Date: Wed Nov 17 01:31:08 2010
> > New Revision: 119480
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=119480&view=rev
> > Log:
> > do not do post checks. Because at this point we just enter the call.
> >
> > Modified:
> >    cfe/trunk/lib/Checker/GRCXXExprEngine.cpp
> >
> > Modified: cfe/trunk/lib/Checker/GRCXXExprEngine.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/GRCXXExprEngine.cpp?rev=119480&r1=119479&r2=119480&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/lib/Checker/GRCXXExprEngine.cpp (original)
> > +++ cfe/trunk/lib/Checker/GRCXXExprEngine.cpp Wed Nov 17 01:31:08 2010
> > @@ -192,10 +192,6 @@
> >     state =
> state->bindLoc(loc::MemRegionVal(ThisR),state->getSVal(ObjArgExpr));
> >     SetupThis.Add(Builder->generateNode(Loc, state, *I));
> >   }
> > -
> > -  // Perform post-visit.
> > -  CheckerVisit(MCE, Dst, /* FIXME: don't forget to update later */
> SetupThis,
> > -               PostVisitStmtCallback);
> > }
> >
> > void GRExprEngine::VisitCXXNewExpr(const CXXNewExpr *CNE, ExplodedNode
> *Pred,
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101118/9b2de95f/attachment.html>