[cfe-commits] r118991 - in /cfe/trunk: lib/Analysis/CFG.cpp test/Analysis/temp-obj-dtors-cfg-output.cpp

[Ted Kremenek]

Ah, okay.

On Nov 15, 2010, at 5:27 PM, Zhongxing Xu wrote:

> 
> 
> On Mon, Nov 15, 2010 at 11:41 PM, Ted Kremenek <kremenek at apple.com> wrote:
> 
> On Nov 15, 2010, at 12:10 AM, Zhongxing Xu wrote:
> 
>> I think that we should leave destructors for temporaries as an option. Also I think we shouldn't optimize elidable constructors and destructors they impact in the CFG, because this will force clients to also account for those optimizations. This will complicate things without any gain for analysis outcome.
>> 
>> To clarify, I didn't optimize away elidable constructors. They are just not appended as block-level expr. They still exist in the CFG. 
>> 
> 
> I haven't had time to look at these set of patches yet, but one high-level comment is that I thought a key design point was to leave all destructor calls as block-level exprs.  That way we can associate call enter/return edges with them if we choose to analyze them via inlining.
> 
> Yeah, I reverted this patch yesterday. 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101115/e61d768e/attachment.html>