[cfe-commits] r119281 - /cfe/trunk/tools/libclang/CIndex.cpp

[Ted Kremenek]

Absolutely.  I'll fix.

On Nov 15, 2010, at 2:45 PM, Frits van Bommel wrote:

> On Mon, Nov 15, 2010 at 11:23 PM, Ted Kremenek <kremenek at apple.com> wrote:
>> -  bool VisitDataRecursive(Stmt *S);
>> +  bool VisitDataRecursive(Stmt *S) __attribute__((noinline));
> 
> Shouldn't that be
>  #include "llvm/Support/Compiler.h"
>  // ...
>  bool VisitDataRecursive(Stmt *S) LLVM_ATTRIBUTE_NOINLINE;
> ?
> 
> That way you also support MSVC, and shouldn't error out on compilers
> that don't support __attribute__((noinline)).