[cfe-commits] [PATCH][CodeGen] Add padding to expanded struct function arguments if the ABI requires it.

Michael Spencer bigcheesegs at gmail.com
Fri Nov 12 19:52:08 PST 2010


On Fri, Nov 12, 2010 at 10:14 PM, John McCall <rjmccall at apple.com> wrote:
> On Oct 18, 2010, at 11:54 PM, Michael Spencer wrote:
>> The Microsoft ABI requires that structs passed by value as "expanded"
>> arguments maintain padding. This patch implements this and fixes
>> <http://llvm.org/bugs/show_bug.cgi?id=8398>.
>
> Sorry this has taken so long.  Can you explain how this approach is different from just not passing the struct as expanded at all, i.e. passing it byval?
>
> John.

I thought byval was a pointer thing, would it work in this case?

See: http://llvm.org/bugs/show_bug.cgi?id=8398

- Michael Spencer




More information about the cfe-commits mailing list