[cfe-commits] r118783 - in /cfe/trunk: test/Index/recursive-cxx-member-calls.cpp tools/libclang/CIndex.cpp

[Douglas Gregor]

On Nov 11, 2010, at 3:28 PM, Ted Kremenek wrote:

> 
> On Nov 11, 2010, at 6:51 AM, Douglas Gregor wrote:
> 
>> 
>> On Nov 11, 2010, at 2:05 AM, Ted Kremenek wrote:
>> 
>>> Author: kremenek
>>> Date: Thu Nov 11 02:05:23 2010
>>> New Revision: 118783
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=118783&view=rev
>>> Log:
>>> Annotate tokens in a separate thread to avoid blowing out stack space.  While the CursorVisitor
>>> is gradually becoming more data recursive, AnnotateTokensVisitor does its own recursive call
>>> within the visitor that can still blow out the stack.  This can potentially be reworked to avoid this,
>>> but for now just do token annotation on a separate thread.
>> 
>> In this case, clang_getCursor() is another candidate for execution on a separate thread.
>> 
>> 	- Doug
> 
> clang_getCursor() should be fine as is.  The function GetCursorVisitor() doesn't actually call 'VisitChildren()' directly, which is what AnnotateTokensVisitor does (which circumvents the data-recursive traversal).

Ah, thanks for the clarification!

	- Doug
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101111/b67315c7/attachment.html>