[cfe-commits] r118475 - in /cfe/trunk: include/clang/Basic/Builtins.def lib/AST/ASTContext.cpp test/CodeGenObjC/implicit-objc_msgSend.m

Fariborz Jahanian fjahanian at apple.com
Mon Nov 8 18:24:09 PST 2010


Author: fjahanian
Date: Mon Nov  8 20:24:08 2010
New Revision: 118475

URL: http://llvm.org/viewvc/llvm-project?rev=118475&view=rev
Log:
Reverse patch for // rdar://8632525. It might
has broken a build.

Modified:
    cfe/trunk/include/clang/Basic/Builtins.def
    cfe/trunk/lib/AST/ASTContext.cpp
    cfe/trunk/test/CodeGenObjC/implicit-objc_msgSend.m

Modified: cfe/trunk/include/clang/Basic/Builtins.def
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Builtins.def?rev=118475&r1=118474&r2=118475&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/Builtins.def (original)
+++ cfe/trunk/include/clang/Basic/Builtins.def Mon Nov  8 20:24:08 2010
@@ -29,8 +29,6 @@
 //  d -> double
 //  z -> size_t
 //  F -> constant CFString
-//  G -> id
-//  H -> SEL
 //  a -> __builtin_va_list
 //  A -> "reference" to __builtin_va_list
 //  V -> Vector, following num elements and a base type.
@@ -561,8 +559,11 @@
 // POSIX setjmp.h
 LIBBUILTIN(_longjmp, "vJi",       "fr",    "setjmp.h")
 LIBBUILTIN(siglongjmp, "vSJi",    "fr",    "setjmp.h")
+
+// FIXME: This type isn't very correct, it should be
 //   id objc_msgSend(id, SEL)
-LIBBUILTIN(objc_msgSend, "GGH.",   "f",     "objc/message.h")
+// but we need new type letters for that.
+LIBBUILTIN(objc_msgSend, "v*.",   "f",     "objc/message.h")
 BUILTIN(__builtin_objc_memmove_collectable, "v*v*vC*z", "nF")
 
 // Builtin math library functions

Modified: cfe/trunk/lib/AST/ASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=118475&r1=118474&r2=118475&view=diff
==============================================================================
--- cfe/trunk/lib/AST/ASTContext.cpp (original)
+++ cfe/trunk/lib/AST/ASTContext.cpp Mon Nov  8 20:24:08 2010
@@ -5384,12 +5384,6 @@
   case 'F':
     Type = Context.getCFConstantStringType();
     break;
-  case 'G':
-    Type = Context.getObjCIdType();
-    break;
-  case 'H':
-    Type = Context.getObjCSelType();
-    break;
   case 'a':
     Type = Context.getBuiltinVaListType();
     assert(!Type.isNull() && "builtin va list type not initialized!");

Modified: cfe/trunk/test/CodeGenObjC/implicit-objc_msgSend.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/implicit-objc_msgSend.m?rev=118475&r1=118474&r2=118475&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenObjC/implicit-objc_msgSend.m (original)
+++ cfe/trunk/test/CodeGenObjC/implicit-objc_msgSend.m Mon Nov  8 20:24:08 2010
@@ -1,5 +1,5 @@
 // RUN: %clang_cc1 -triple x86_64-apple-darwin9 -emit-llvm -o %t %s
-// RUN: grep -F 'declare i8* @objc_msgSend(i8*, i8*, ...)' %t
+// RUN: grep -F 'declare i8* @objc_msgSend(...)' %t
 
 typedef struct objc_selector *SEL;
 id f0(id x, SEL s) {





More information about the cfe-commits mailing list