[cfe-commits] r117539 - in /cfe/trunk: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Stmt.cpp lib/CodeGen/CGStmt.cpp lib/Sema/JumpDiagnostics.cpp test/Sema/scope-check.c test/SemaCXX/scope-check.cpp

John McCall rjmccall at apple.com
Thu Oct 28 18:18:02 PDT 2010


On Oct 28, 2010, at 9:09 AM, Chris Lattner wrote:

> 
> On Oct 28, 2010, at 1:53 AM, John McCall wrote:
> 
>> Author: rjmccall
>> Date: Thu Oct 28 03:53:48 2010
>> New Revision: 117539
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=117539&view=rev
>> Log:
>> Implement an indirect-goto optimization for goto *&&lbl and respect this
>> in the scope checker.  With that done, turn an indirect goto into a
>> protected scope into a hard error;  otherwise IR generation has to start
>> worrying about declarations not dominating their scopes, as exemplified
>> in PR8473.
>> 
>> If this really affects anyone, I can probably adjust this to only hard-error
>> on possible indirect gotos into VLA scopes rather than arbitrary scopes.
>> But we'll see how people cope with the aggressive change on the marginal
>> feature.
> 
> Does this break the webkit build?


(I just saw this message)

No.  Or, it doesn't break the JSC build, which IIRC is the only part using indirect goto.

John.



More information about the cfe-commits mailing list