[cfe-commits] r117220 - in /cfe/trunk: lib/Analysis/CFG.cpp test/Sema/warn-unreachable.c

Ted Kremenek kremenek at apple.com
Mon Oct 25 15:39:16 PDT 2010

On Oct 25, 2010, at 3:25 PM, Marcin Świderski wrote:

> Because:
> 1. removing the check after swaping the order did not crash tests,

The existing test probably only checked the inverse case.  When in doubt, it is worth verifying the original test that failed (before your changes, by removing the sanity checking), and seeing if it needs to modified/copied to the new case.  This kind of sanity checking in the CFGBuilder was not added arbitrarily; it has been built up from esoteric cases people have provided over the last couple years.

> 2. VisitChildren() is implemented this way,
> I assumed that this is the right way to go. If I'm mistaken then shouldn't we add such check in other places with similar code e.g. VisitChildren()?

Good point.  It probably needs to be modified as well.

More information about the cfe-commits mailing list