[cfe-commits] [PATCH] Teach printf warnings about small integer types.

[Ted Kremenek]

On Oct 20, 2010, at 9:25 PM, Justin Bogner wrote:

> On Thu, Oct 21, 2010 at 12:05 AM, Ted Kremenek <kremenek at apple.com> wrote:
>> I went ahead applied this patch (with a few modifications) here:
>> 
>>  http://llvm.org/viewvc/llvm-project?view=rev&revision=116996
> 
> Thanks Ted, I'm out of town and didn't have time to get to it yet.
> Where is isa<>
> defined, by the way?

isa<> and dyn_cast<> are defined in 'llvm/Support/Casting.h', but more useful documentation can be found here:

http://llvm.org/docs/ProgrammersManual.html#isa

> 
>> I mainly incorporated my minor nits I commented on in my last email.
>> I also needed to modify the test case slightly to use 'typedef'
>> instead of '#define'.  Even though they might appear to be correct,
>> please make sure that the test cases actually pass before submitting
>> patches.
> 
> Well that's embarrassing. I'll have to be more careful to make sure
> what I test and
> what I send actually sync up.

No worries.  We've all made that mistake.