[cfe-commits] r116930 - /cfe/trunk/lib/Serialization/ASTReaderDecl.cpp

[Argyrios Kyrtzidis]

Author: akirtzidis
Date: Wed Oct 20 11:22:49 2010
New Revision: 116930

URL: http://llvm.org/viewvc/llvm-project?rev=116930&view=rev
Log:
Minor optimization; Try to iterator over redeclarations only when necessary.

Modified:
    cfe/trunk/lib/Serialization/ASTReaderDecl.cpp

Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReaderDecl.cpp?rev=116930&r1=116929&r2=116930&view=diff
==============================================================================
--- cfe/trunk/lib/Serialization/ASTReaderDecl.cpp (original)
+++ cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Wed Oct 20 11:22:49 2010
@@ -769,15 +769,14 @@
   // We need to allocate the DefinitionData struct ahead of VisitRecordDecl
   // so that the other CXXRecordDecls can get a pointer even when the owner
   // is still initializing.
-  bool OwnsDefinitionData = false;
   enum DataOwnership { Data_NoDefData, Data_Owner, Data_NotOwner };
-  switch ((DataOwnership)Record[Idx++]) {
+  DataOwnership DefOwnership = (DataOwnership)Record[Idx++];
+  switch (DefOwnership) {
   default:
     assert(0 && "Out of sync with ASTDeclWriter or messed up reading");
   case Data_NoDefData:
     break;
   case Data_Owner:
-    OwnsDefinitionData = true;
     D->DefinitionData = new (C) struct CXXRecordDecl::DefinitionData(D);
     break;
   case Data_NotOwner:
@@ -788,11 +787,11 @@
 
   VisitRecordDecl(D);
 
-  if (D->DefinitionData) {
-    // Synchronize the DefinitionData pointer among all redeclarations.
-    // This synchronization ends up being done multiple times but it's necessary
-    // because a chained PCH may introduce a definition that earlier
-    // redeclarations in another PCH have no information about.
+  // Spread the DefinitionData pointer if it's the definition (it may have
+  // come from a chained PCH and earlier redeclarations don't know it), or
+  // if it just acquired a pointer that it's not supposed to have (a definition
+  // from a chained PCH updated it).
+  if (D->DefinitionData && DefOwnership != Data_NotOwner) {
     llvm::SmallPtrSet<CXXRecordDecl *, 16> PrevRedecls;
     PrevRedecls.insert(D);
     CXXRecordDecl *Redecl = cast<CXXRecordDecl>(D->RedeclLink.getNext());
@@ -806,7 +805,7 @@
     }
   }
 
-  if (OwnsDefinitionData) {
+  if (DefOwnership == Data_Owner) {
     assert(D->DefinitionData);
     struct CXXRecordDecl::DefinitionData &Data = *D->DefinitionData;