[cfe-commits] PATCH: Adds support for --sysroot flag

[Chandler Carruth]

On Tue, Oct 19, 2010 at 12:12 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 18 October 2010 20:45, Chandler Carruth <chandlerc at google.com> wrote:
> > This patch adds support for the --sysroot flag. It does so by passing the
> > -isysroot down to Clang's CC1. The existing logic already passed the flag
> to
> > the linker, which may or may not reject in on some systems.
> > Any concerns about this implementation strategy?
>
> The comment looks correct, but aren't you adding a -isysroot to the
> cc1 invocation even if we have an explicit -isysroot?
>

Doh! Added that bit.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101019/3772cd35/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sysroot_flag.patch
Type: application/octet-stream
Size: 788 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101019/3772cd35/attachment.obj>