[cfe-commits] [win32][review request] clang Index test fix

Francois Pichet pichet2000 at gmail.com
Mon Oct 11 17:34:20 PDT 2010


Hi Doug
This is the fix for remap-complete.c..
It is still failing

On Sun, Oct 3, 2010 at 8:50 PM, Francois Pichet <pichet2000 at gmail.com> wrote:
> This patch remove the Win32 XFAIL from test/Index/remap-complete.c and
> test/Index/remap-load.c
> The problem was that text files were open in text mode and Microsoft
> implementation of fread and write will try to do nasty line-feed
> conversion which make the line position no longer valid.
> I think the option llvm::raw_fd_ostream::F_Binary should always be
> used. Or it should be removed and always applied. Or else we are going
> to have more problem with that.

More information about the cfe-commits mailing list