[cfe-commits] r111726 - in /cfe/trunk: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h test/CodeGen/address-space-field1.c test/CodeGen/packed-structure.c

[John McCall]

On Sep 29, 2010, at 9:11 AM, Daniel Dunbar wrote:

> On Fri, Aug 20, 2010 at 9:35 PM, John McCall <rjmccall at apple.com> wrote:
>> On Aug 20, 2010, at 9:20 PM, Daniel Dunbar wrote:
>>> URL: http://llvm.org/viewvc/llvm-project?rev=111726&view=rev
>>> Log:
>>> IRgen: Set the alignment correctly when creating LValue for a decls.
>>> - Fixes PR5598.
>>> - Review appreciated.
>> 
>> The idea seems good;  I haven't reviewed the details.  Is there a good
>> reason you're using an unsigned everywhere instead of a CharUnits?
> 
> It is using CharUnits in between, the unsigned's are just temporary
> variables before passing to the backend. Or did I miss something?

MakeAddrLValue is not the backend. :)  There's no reason for this method
to not take a CharUnits instead of an unsigned.

John.