[cfe-commits] [PATCH] CFGElement print

[Marcin Świderski]

Added comments.

I thought about tests myself but don't really know how should we go about
them? I mean that for now destructors will probably be off by default. How
to print CFG using the driver? How to set up testing the output?

W dniu 21 września 2010 03:24 użytkownik Ted Kremenek
<kremenek at apple.com>napisał:

> Looks great!
>
> Please add doxygen comments about CFGInitializer and CFGAutomaticObjDtor
> respectively.  We should get in the habit of documenting such core classes
> in the static analyzer.
>
> We also should probably add a FileCheck-based test to test/Analysis that
> tests CFG printing (particularly these new pieces), since it has broken in
> the past.  Now that we're adding new CFGElements, now seems like a good time
> to start testing this.
>
> On Sep 20, 2010, at 4:42 PM, Marcin Świderski wrote:
>
> > This patch:
> > - defines interfaces for CFGInitializer and CFGAutomaticObjDtor,
> > - adds support for above classes to print_elem function (renamed
> print_stmt)
> >
> > I've extended StmtPrinterHelper to print locations of VarDecls for
> destructors.
> >
> > Please aprove for commit,
> >
> > Marcin
> > <cfg-print-elem.patch>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100921/5ee546ab/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfg-print-elem.patch
Type: application/octet-stream
Size: 9380 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100921/5ee546ab/attachment.obj>