[cfe-commits] r113974 - /cfe/trunk/lib/Driver/Tools.cpp

[Fariborz Jahanian]

On Sep 15, 2010, at 1:44 PM, Jakob Stoklund Olesen wrote:

>
> On Sep 15, 2010, at 11:57 AM, Fariborz Jahanian wrote:
>
>>
>> On Sep 15, 2010, at 10:38 AM, Jakob Stoklund Olesen wrote:
>>
>>>
>>> On Sep 15, 2010, at 9:00 AM, Fariborz Jahanian wrote:
>>>
>>>> Author: fjahanian
>>>> Date: Wed Sep 15 11:00:51 2010
>>>> New Revision: 113974
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=113974&view=rev
>>>> Log:
>>>> Make the new -fobjc-nonfragile-abi2 the default
>>>> abi for clang's objective-c compilations.
>>>> (radar 8353555).
>>>
>>> Hi Fariborz,
>>>
>>> This broke the dot-syntax-1 test in the nightly test suite.
>>>
>>> http://smooshlab.apple.com:8010/builders/clang-x86_64-darwin10-fnt/builds/4149
>>
>> Output of the test case is correctly changed under the new -fobjc- 
>> nonfragile-abi2 (now the dafault).
>> How and where do I change the Output file?
>
> You check in an updated dot-syntax-1.reference_output to the test  
> suite.
Thanks. I just found out that I needed to update to get the output  
files.
>
>
> Please wait until we get a green light on checking in stuff to the  
> test-suite from John Criswell.
I was told that others have been committing; so I did too. Sorry if I  
was misinformed.
>
>
> This means that dot-syntax-1 will start failing when built with llvm- 
> gcc, just like dot-syntax-2 already is.

Thanks is correct.

>
>
> I assume that this ABI incompatibility between clang and llvm-gcc is  
> a known issue.

This is the new objective-c abi. There is no such abi in gcc/llvm-gcc.  
So from now on, people who want
to stay with old (nonfragile) abi, must add -fobjc-nonfragile-abi on  
clang's  command line.

- Fariborz


>
>
> /jakob
>