[cfe-commits] r113974 - /cfe/trunk/lib/Driver/Tools.cpp

[Fariborz Jahanian]

Author: fjahanian
Date: Wed Sep 15 11:00:51 2010
New Revision: 113974

URL: http://llvm.org/viewvc/llvm-project?rev=113974&view=rev
Log:
Make the new -fobjc-nonfragile-abi2 the default
abi for clang's objective-c compilations.
(radar 8353555).

Modified:
    cfe/trunk/lib/Driver/Tools.cpp

Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=113974&r1=113973&r2=113974&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Wed Sep 15 11:00:51 2010
@@ -1244,20 +1244,27 @@
   // -fobjc-nonfragile-abi=0 is default.
   if (types::isObjC(InputType)) {
     unsigned Version = 1;
-    if (Args.hasArg(options::OPT_fobjc_nonfragile_abi) ||
-        getToolChain().IsObjCNonFragileABIDefault())
+    if (Args.hasArg(options::OPT_fobjc_nonfragile_abi))
       Version = 2;
+    else if (Args.hasArg(options::OPT_fobjc_nonfragile_abi2) ||
+             getToolChain().IsObjCNonFragileABIDefault())
+      Version = 3;
     if (Arg *A = Args.getLastArg(options::OPT_fobjc_abi_version_EQ)) {
       if (llvm::StringRef(A->getValue(Args)) == "1")
         Version = 1;
       else if (llvm::StringRef(A->getValue(Args)) == "2")
         Version = 2;
+      else if (llvm::StringRef(A->getValue(Args)) == "3")
+        Version = 3;
       else
         D.Diag(clang::diag::err_drv_clang_unsupported) << A->getAsString(Args);
     }
-
-    if (Version == 2) {
-      CmdArgs.push_back("-fobjc-nonfragile-abi");
+  
+    if (Version == 2 || Version == 3) {
+      if (Version == 2)
+        CmdArgs.push_back("-fobjc-nonfragile-abi");
+      else
+        CmdArgs.push_back("-fobjc-nonfragile-abi2");
 
       // -fobjc-dispatch-method is only relevant with the nonfragile-abi, and
       // legacy is the default.
@@ -1270,11 +1277,6 @@
           CmdArgs.push_back("-fobjc-dispatch-method=non-legacy");
       }
     }
-
-    // FIXME: -fobjc-nonfragile-abi2 is a transient option meant to expose
-    // features in testing.  It will eventually be removed.
-    if (Args.hasArg(options::OPT_fobjc_nonfragile_abi2))
-      CmdArgs.push_back("-fobjc-nonfragile-abi2");
   }
 
   if (!Args.hasFlag(options::OPT_fassume_sane_operator_new,