[cfe-commits] [PATCH] Fix pointer arithmetic for Windows64 target

Chris Lattner clattner at apple.com
Tue Sep 14 15:23:28 PDT 2010


On Sep 14, 2010, at 3:20 PM, Cameron Esfahani wrote:

> I don't have commit access, so if you or someone else could do it...

Lets fix the real problem! Please read through http://llvm.org/docs/DeveloperPolicy.html and send me the requested info, thanks!

-Chris

> 
> On Sep 14, 2010, at 3:17 PM, Chris Lattner wrote:
> 
>> Looks great to me, please commit!
>> 
>> On Sep 14, 2010, at 2:39 PM, Cameron Esfahani wrote:
>> 
>>> Enclosed is a patch which updates the Target information for the Windows64 target.  Windows defines long and int as being 32-bits for the Windows64 ABI.  Previous to this patch, this was causing pointer arithmetic to generate sign extensions and kooky code generation.  I also updated a few other target attributes to be more inline with what Microsoft documents.
>>> 
>>> Act now, and get a free test case!
>>> 
>>> <clang.patch>
>>> 
>>> Cameron Esfahani
>>> dirty at apple.com
>>> 
>>> "We do what we must because we can."
>>> 
>>> Aperture Science
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
> 
> Cameron Esfahani
> dirty at apple.com
> 
> "We do what we must because we can."
> 
> Aperture Science
> 
> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list