[cfe-commits] [PATCH] Analysis/CFG Build options

[Ted Kremenek]

On Sep 14, 2010, at 12:07 AM, Marcin Świderski wrote:

> Hi
> 
> This patch implements named parameter idiom for CFG::buildCFG options.
> 
> Cheers,
> Marcin
> 
> PS. I can't see messages I send on cfe-commits. Should I send patches to cfe-dev?
> <cfg-build-options.patch>

Looks great.  Minor nit:

+    bool PruneTriviallyFalseEdges:1;
+    bool AddEHEdges:1;
+    bool AddInitializers:1;
+    bool AddImplicitDtors:1;

These probably need to be 'unsigned' instead of 'bool'.  I vaguely recall bool bitfields to be a problem for Visual C++ (treats them as signed?).  The Clang codebase seems inconsistent, so I'm going to ask a question on cfe-dev.