[cfe-commits] r112839 - in /cfe/trunk: include/clang/Checker/BugReporter/BugReporter.h lib/Checker/BugReporterVisitors.cpp lib/Checker/IdempotentOperationChecker.cpp

[Jakob Stoklund Olesen]

On Sep 2, 2010, at 10:49 AM, Tom Care wrote:

> Author: tcare
> Date: Thu Sep  2 12:49:20 2010
> New Revision: 112839
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=112839&view=rev
> Log:
> Improved error reporting in IdempotentOperationChecker
> - SourceRange highlighting is only given for the relevant side of the operator (assignments give both)
> - Added PostVisitBinaryOperator hook to retrieve the ExplodedNode for an operator
> - Added a BugReporterVisitor to display the last store to every VarDecl in a Stmt
> - Changed bug reporting to use the new BugReporterVisitor
> 
> Modified:
>    cfe/trunk/include/clang/Checker/BugReporter/BugReporter.h
>    cfe/trunk/lib/Checker/BugReporterVisitors.cpp
>    cfe/trunk/lib/Checker/IdempotentOperationChecker.cpp

Hi Tom,

I think you broke the build (using gcc-4.2):

/Volumes/Data/g/clang/lib/Checker/IdempotentOperationChecker.cpp:94: error: declaration of ‘<unnamed>::IdempotentOperationChecker::Assumption <unnamed>::IdempotentOperationChecker::<anonymous struct>::Assumption’
/Volumes/Data/g/clang/lib/Checker/IdempotentOperationChecker.cpp:73: error: changes meaning of ‘Assumption’ from ‘enum<unnamed>::IdempotentOperationChecker::Assumption’
/Volumes/Data/g/clang/lib/Checker/IdempotentOperationChecker.cpp:95: error: declaration of ‘clang::AnalysisContext* <unnamed>::IdempotentOperationChecker::<anonymous struct>::AnalysisContext’
/Volumes/Data/g/clang/lib/Checker/../../include/clang/Analysis/AnalysisContext.h:42: error: changes meaning of ‘AnalysisContext’ from ‘class clang::AnalysisContext’

/jakob