[cfe-commits] r112691 - in /cfe/trunk: include/clang/AST/DeclObjC.h lib/AST/ASTContext.cpp lib/AST/ASTImporter.cpp lib/AST/DeclObjC.cpp lib/CodeGen/CGObjCMac.cpp lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaDeclObjC.cpp lib/Sema/SemaLookup.cpp lib/Sema/SemaObjCProperty.cpp lib/Serialization/ASTReaderDecl.cpp lib/Serialization/ASTWriterDecl.cpp test/Index/local-symbols.m

Fariborz Jahanian fjahanian at apple.com
Wed Sep 1 12:39:43 PDT 2010


On Sep 1, 2010, at 12:36 PM, Douglas Gregor wrote:

>
> On Sep 1, 2010, at 11:08 AM, Fariborz Jahanian wrote:
>
>>
>> On Sep 1, 2010, at 9:19 AM, Ted Kremenek wrote:
>>
>>> Hi Fariborz,
>>>
>>> I thought about this (after emailing you off the list), and while I
>>> agree that the naming should be better I'm not certain about using
>>> "Declared."  The protocols aren't actually declared, but are
>>> referenced.  Using "Declared" seems to conflate this concept with
>>> actual declarations.
>>
>> Using Referenced and AllReferenced are somewhat confusing. Somehow,
>> first one should refer to the declared list.
>> But, if you cannot think of something better, it is ok with me.
>
> In other places in the AST, we've used the "AsWritten" suffix to  
> identify functions that return the syntactic view of the AST.

Yes, I like AsWritten as we have used it in other places.

- fariborz

>
>
> 	- Doug




More information about the cfe-commits mailing list