[cfe-commits] [PATCH] Compatibility with GCC 4.6 #pragma GCC diagnostics

[Douglas Gregor]

On Aug 18, 2010, at 11:30 AM, Louis Gerbarg wrote:

> On Wed, Aug 18, 2010 at 10:34 AM, Douglas Gregor <dgregor at apple.com> wrote:
>> 
>> On Aug 17, 2010, at 10:43 AM, Louis Gerbarg wrote:
>> 
>>> GCC 4.6 has apparently added support for #pragma push/pop (see this
>>> thread for more details
>>> <http://gcc.gnu.org/ml/gcc-patches/2010-06/msg01163.html>), using the
>>> exact same identifier and semantics as the existing implementation in
>>> clang. This patch removes the special clang mode in the diagnostic
>>> handler, which lets the GCC pragmas fall through to the existing code.
>>> Overall it is a simplification of the existing code. This patch also
>>> includes modified test cases to handle altered semantics of the GCC
>>> mode behavior.
>> 
>> I briefly considered whether we want to think about some kind of version check (e.g., warn if GCC-compatibility-version < 4.6), but going in that direction will drive us insane. So...
> 
> I considered it too, but I also concluded that way leads to madness.
> 
>> Your patch looks good, but could you submit it again as an attachment instead of inline? It doesn't cleanly apply for me this way (http://llvm.org/docs/DeveloperPolicy.html#patches)
> 
> Sorry about that, here is the patch again.


Thanks! Committed as r112484.

	- Doug