[cfe-commits] [PATCH] - Preprocessor bug on WIN32 (PR 7953) - Windows filename are case insensitive.

Chris Lattner clattner at apple.com
Mon Aug 23 16:51:35 PDT 2010


On Aug 21, 2010, at 1:51 PM, Francois Pichet wrote:

> This is a small patch to fix PR 7953.
> (http://llvm.org/bugs/show_bug.cgi?id=7953)
> 
> #pragma once wasn't working on win32 if the header file was included
> using a different case.
> I tracked down  the problem to the fact that clang::FileManager was
> caching files using case sensitive string (UniqueFiles) on Windows.
> 
> I changed FileManager to cache filename in lower case only.
> Doesn't affect UNIX because UNIX uses Inode to uniquely identify files.

Looks great to me, applied in r111866.  Thanks!

-Chris



More information about the cfe-commits mailing list