[cfe-commits] [PATCH] Move ExecuteCompilerInvocation to a new library Actions

Daniel Dunbar daniel at zuster.org
Thu Aug 19 09:16:42 PDT 2010


Hi Peter,

Looks good, but I find the name confusing. Actions makes me think its
the place I should put new actions, which is wrong. In practice, this
library will only ever have code to support the unified frontend --
what about FrontendTool?

 - Daniel

On Wed, Aug 18, 2010 at 6:51 AM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> Hi,
>
> r110903 introduced a dependency from Frontend to every library that
> declared an Action by introducing Action references that previously
> resided in the driver in the file ExecuteCompilerInvocation.cpp.
> This patch moves ExecuteCompilerInvocation to a new library named
> Actions which is intended to bear these dependencies.
>
> OK to commit?
>
> Thanks,
> --
> Peter
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>



More information about the cfe-commits mailing list