[cfe-commits] r111097 - /cfe/trunk/lib/Checker/MallocChecker.cpp

[Ted Kremenek]

On Aug 15, 2010, at 1:19 AM, Zhongxing Xu wrote:

> +  for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
> +    if (SymReaper.isDead(I->first)) {
> +      if (I->second.isAllocated()) {
> +        if (ExplodedNode *N = C.GenerateSink()) {
> +          if (!BT_Leak)


Hi Zhongxing,

I don't think we should be using GenerateSink() here.  There is no reason the halt the analysis of a path because we flag a leak.  We typically only use GenerateSink() for bugs that would cause the analysis of the remainder of the path meaningless (e.g., a null dereference).

Ted