[cfe-commits] r111087 - in /cfe/trunk/lib: AST/RecordLayoutBuilder.cpp Frontend/VerifyDiagnosticsClient.cpp

Douglas Gregor dgregor at apple.com
Sat Aug 14 20:25:21 PDT 2010


On Aug 14, 2010, at 6:15 PM, Argyrios Kyrtzidis wrote:

> Author: akirtzidis
> Date: Sat Aug 14 20:15:27 2010
> New Revision: 111087
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=111087&view=rev
> Log:
> Add ATTRIBUTE_UNUSED to methods not supposed to be used.
> 
> Modified:
>    cfe/trunk/lib/AST/RecordLayoutBuilder.cpp
>    cfe/trunk/lib/Frontend/VerifyDiagnosticsClient.cpp
> 
> Modified: cfe/trunk/lib/AST/RecordLayoutBuilder.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/RecordLayoutBuilder.cpp?rev=111087&r1=111086&r2=111087&view=diff
> ==============================================================================
> --- cfe/trunk/lib/AST/RecordLayoutBuilder.cpp (original)
> +++ cfe/trunk/lib/AST/RecordLayoutBuilder.cpp Sat Aug 14 20:15:27 2010
> @@ -660,8 +660,9 @@
> 
>   void UpdateAlignment(unsigned NewAlignment);
> 
> -  RecordLayoutBuilder(const RecordLayoutBuilder&);   // DO NOT IMPLEMENT
> -  void operator=(const RecordLayoutBuilder&); // DO NOT IMPLEMENT
> +  // DO NOT IMPLEMENT
> +  RecordLayoutBuilder(const RecordLayoutBuilder&) ATTRIBUTE_UNUSED;
> +  void operator=(const RecordLayoutBuilder&) ATTRIBUTE_UNUSED;
> public:
>   static const CXXMethodDecl *ComputeKeyFunction(const CXXRecordDecl *RD);
> };


This is a fairly common pattern in C++ code. Should we really be warning about it? There's no definition of these functions, IIUC.

	- Doug



More information about the cfe-commits mailing list