[cfe-commits] r111005 - in /cfe/trunk: include/clang/Driver/OptParser.td include/clang/Driver/OptTable.h include/clang/Driver/Option.h include/clang/Driver/Options.td lib/Driver/OptTable.cpp lib/Driver/Option.cpp test/Driver/gcc_forward.c

[Daniel Dunbar]

On Fri, Aug 13, 2010 at 5:13 PM, Benjamin Kramer
<benny.kra at googlemail.com> wrote:
>
> On 13.08.2010, at 06:44, Daniel Dunbar wrote:
>
>> Author: ddunbar
>> Date: Thu Aug 12 23:44:20 2010
>> New Revision: 111005
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=111005&view=rev
>> Log:
>> Driver/OptParser: Add a NoForward flag to prevent forwarding certain options to
>> GCC.
>> - Mark -Xclang and -mlinker-version= with it for now, although I am sure there
>>   are more.
> […]
>> Modified: cfe/trunk/include/clang/Driver/OptTable.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/OptTable.h?rev=111005&r1=111004&r2=111005&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Driver/OptTable.h (original)
>> +++ cfe/trunk/include/clang/Driver/OptTable.h Thu Aug 12 23:44:20 2010
>> @@ -25,10 +25,11 @@
>>     HelpHidden       = (1 << 1),
>>     LinkerInput      = (1 << 2),
>>     NoArgumentUnused = (1 << 3),
>> -    RenderAsInput    = (1 << 4),
>> -    RenderJoined     = (1 << 5),
>> -    RenderSeparate   = (1 << 6),
>> -    Unsupported      = (1 << 7)
>> +    NoForward        = (1 << 4),
>> +    RenderAsInput    = (1 << 5),
>> +    RenderJoined     = (1 << 6),
>> +    RenderSeparate   = (1 << 7),
>> +    Unsupported      = (1 << 8)
>>   };
>
> We store this flag in an unsigned char in OptTable::Info, so this is one bit too much.
> OTOH all options that were flagged as unsupported are supported now ;)

Nice catch, will fix.

 - Daniel