[cfe-commits] [PATCH] mult-alt constraint fix

[Chris Lattner]

On Aug 10, 2010, at 5:43 PM, John Thompson wrote:

> Apparently, "=r,m" constraints are legal.  This fixes pr7869.  Permission to check-in?

Ok with a testcase and no regressions on the testsuite.

-Chris

>  
> Index: lib/Basic/TargetInfo.cpp
> ===================================================================
> --- lib/Basic/TargetInfo.cpp (revision 110706)
> +++ lib/Basic/TargetInfo.cpp (working copy)
> @@ -289,11 +289,9 @@
>        break;
>      case ',': // multiple alternative constraint.  Pass it.
>        Name++;
> -      // An output constraint must start with '=' or '+'
> -      if (*Name != '=' && *Name != '+')
> -        return false;
> -      if (*Name == '+')
> -        Info.setIsReadWrite();
> +      // Handle additional optional '=' or '+' modifiers.
> +      if (*Name == '=' || *Name == '+')
> +        Name++;
>        break;
>      case '?': // Disparage slightly code.
>      case '!': // Disparage severly.
> 
> 
> -- 
> John Thompson
> John.Thompson.JTSoftware at gmail.com
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100810/8decd6dc/attachment.html>