[cfe-commits] r110314 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaCXX/warn-for-var-in-else.cpp

Nick Lewycky nicholas at mxc.ca
Thu Aug 5 23:51:22 PDT 2010


Chris Lattner wrote:
>
> On Aug 5, 2010, at 10:45 PM, Nick Lewycky wrote:
>
>>>
>>> This is an unfortunate thing to remove, but if you're going to do it, please remove isDeclaredInCondition and the other code that supports this warning but is now dead.
>>
>> Great point, done. Also, I filed PR7823 for the useful parts of this warning, with cautions about how to implement it to avoid the same problems.
>
> What about Scope::ElseScope and the code that feeds it?

Oh, thank you! I'm not sure how I missed that. Fixed in r110433.



More information about the cfe-commits mailing list