[cfe-commits] r110330 - /cfe/trunk/lib/Checker/GRExprEngine.cpp
Ted Kremenek
kremenek at apple.com
Thu Aug 5 08:03:30 PDT 2010
Author: kremenek
Date: Thu Aug 5 10:03:30 2010
New Revision: 110330
URL: http://llvm.org/viewvc/llvm-project?rev=110330&view=rev
Log:
Revert r110317, and add a comment why the assertion is not an invariant.
Modified:
cfe/trunk/lib/Checker/GRExprEngine.cpp
Modified: cfe/trunk/lib/Checker/GRExprEngine.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/GRExprEngine.cpp?rev=110330&r1=110329&r2=110330&view=diff
==============================================================================
--- cfe/trunk/lib/Checker/GRExprEngine.cpp (original)
+++ cfe/trunk/lib/Checker/GRExprEngine.cpp Thu Aug 5 10:03:30 2010
@@ -236,11 +236,11 @@
// If we built NewCO, check if we called all the checkers. This is important
// so that we know that we accurately determined the entire set of checkers
- // that responds to this callback.
- if (NewCO.get()) {
- assert(checkersEvaluated == Checkers.size());
+ // that responds to this callback. Note that 'checkersEvaluated' might
+ // not be the same as Checkers.size() if one of the Checkers generates
+ // a sink node.
+ if (NewCO.get() && checkersEvaluated == Checkers.size())
CO_Ref = NewCO.take();
- }
// Don't autotransition. The CheckerContext objects should do this
// automatically.
More information about the cfe-commits
mailing list