[cfe-commits] r110317 - /cfe/trunk/lib/Checker/GRExprEngine.cpp

[Jordy Rose]

I was wondering that myself. Why do we have that variable in the first
place? Was there a break or continue in an old version of the loop?


On Thu, 05 Aug 2010 07:38:23 -0000, Zhongxing Xu <xuzhongxing at gmail.com>
wrote:
> Author: zhongxingxu
> Date: Thu Aug  5 02:38:23 2010
> New Revision: 110317
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=110317&view=rev
> Log:
> Turn the predicate into an assertion. When could the unequal case
happen?
> 
> Modified:
>     cfe/trunk/lib/Checker/GRExprEngine.cpp
> 
> Modified: cfe/trunk/lib/Checker/GRExprEngine.cpp
> URL:
>
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/GRExprEngine.cpp?rev=110317&r1=110316&r2=110317&view=diff
>
==============================================================================
> --- cfe/trunk/lib/Checker/GRExprEngine.cpp (original)
> +++ cfe/trunk/lib/Checker/GRExprEngine.cpp Thu Aug  5 02:38:23 2010
> @@ -237,8 +237,10 @@
>    // If we built NewCO, check if we called all the checkers.  This is
>    important
>    // so that we know that we accurately determined the entire set of
>    checkers
>    // that responds to this callback.
> -  if (NewCO.get() && checkersEvaluated == Checkers.size())
> +  if (NewCO.get()) { 
> +    assert(checkersEvaluated == Checkers.size());
>      CO_Ref = NewCO.take();
> +  }
>  
>    // Don't autotransition.  The CheckerContext objects should do this
>    // automatically.
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits