[cfe-commits] r110032 - /cfe/trunk/include/clang/Checker/PathSensitive/MemRegion.h

[Chandler Carruth]

On Mon, Aug 2, 2010 at 12:24 AM, Argyrios Kyrtzidis <akyrtzi at gmail.com>wrote:

> Author: akirtzidis
> Date: Mon Aug  2 02:24:29 2010
> New Revision: 110032
>
> URL: http://llvm.org/viewvc/llvm-project?rev=110032&view=rev
> Log:
> Shut up warnings in Release build.
>
> Modified:
>    cfe/trunk/include/clang/Checker/PathSensitive/MemRegion.h
>
> Modified: cfe/trunk/include/clang/Checker/PathSensitive/MemRegion.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Checker/PathSensitive/MemRegion.h?rev=110032&r1=110031&r2=110032&view=diff
>
> ==============================================================================
> --- cfe/trunk/include/clang/Checker/PathSensitive/MemRegion.h (original)
> +++ cfe/trunk/include/clang/Checker/PathSensitive/MemRegion.h Mon Aug  2
> 02:24:29 2010
> @@ -296,6 +296,7 @@
>   /// Compute the offset within the top level memory object.
>   virtual RegionOffset getAsOffset() const {
>     assert(0 && "unimplemented");
>

You should use:

llvm_unreachable("unimplemented");

For this situation. It also avoids complaints in release builds.

+    return RegionOffset(NULL);
>   }
>
>   MemRegionManager* getMemRegionManager() const;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100802/d5dada4f/attachment.html>