[cfe-commits] r109681 - in /cfe/trunk: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_64-arguments.c

[Eli Friedman]

On Wed, Jul 28, 2010 at 3:15 PM, Chris Lattner <sabre at nondot.org> wrote:
> Author: lattner
> Date: Wed Jul 28 17:15:08 2010
> New Revision: 109681
>
> URL: http://llvm.org/viewvc/llvm-project?rev=109681&view=rev
> Log:
> fix PR7714 by not referencing off the end of a struct when passed by value in
> x86-64 abi.  This also improves codegen as well.  Some refactoring is needed of
> this code.

I don't think this properly fixes the problem; take the following:

struct S0 {
  short f0;
  unsigned f1;
  char f2;
  char f3;
  char f4;
};

void func_2(struct S0 p_4)
{
}

Generated code still writes over the end of %p_4.

-Eli