[cfe-commits] r108980 - /cfe/trunk/lib/Basic/Targets.cpp

[Nate Begeman]

On Jul 20, 2010, at 7:36 PM, Daniel Dunbar wrote:

> On Tue, Jul 20, 2010 at 7:02 PM, Nate Begeman <natebegeman at mac.com> wrote:
>> Author: sampo
>> Date: Tue Jul 20 21:02:56 2010
>> New Revision: 108980
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=108980&view=rev
>> Log:
>> Fix win64 compilation of constants like 0xFFFFFFFFFFFFFFFFULL
>> 
>> intmax_t is __int64 (long long to clang), per VS 2010 stdint.h
>> 
>> 
>> Modified:
>>    cfe/trunk/lib/Basic/Targets.cpp
>> 
>> Modified: cfe/trunk/lib/Basic/Targets.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=108980&r1=108979&r2=108980&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Basic/Targets.cpp (original)
>> +++ cfe/trunk/lib/Basic/Targets.cpp Tue Jul 20 21:02:56 2010
>> @@ -1447,7 +1447,9 @@
>>     TLSSupported = false;
>>     WCharType = UnsignedShort;
>>     LongWidth = LongAlign = 32;
>> -    DoubleAlign = LongLongAlign = 64;
> 
> Was this change intentional?

Yes, it's dead code, those are the default values not overridden by any base class  as far as I can tell.

Nate

> 
> - Daniel
> 
>> +    IntMaxType = SignedLongLong;
>> +    UIntMaxType = UnsignedLongLong;
>> +    Int64Type = SignedLongLong;
>>   }
>>   virtual void getTargetDefines(const LangOptions &Opts,
>>                                 MacroBuilder &Builder) const {
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>