[cfe-commits] r108749 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Jim Grosbach grosbach at apple.com
Mon Jul 19 14:13:15 PDT 2010


Right. No corresponding assembler/linker/et.al. changes are necessary.

-Jim

On Jul 19, 2010, at 2:07 PM, Fariborz Jahanian wrote:

> Hi Jim,
> 
> This patch does not require any corresponding tool changes?
> 
> - Fariborz
> 
> On Jul 19, 2010, at 1:54 PM, Jim Grosbach wrote:
> 
>> Author: grosbach
>> Date: Mon Jul 19 15:54:43 2010
>> New Revision: 108749
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=108749&view=rev
>> Log:
>> Put ObjC method names, method types and class names in separate string literal
>> sections. rdar://8207705
>> 
>> 
>> Modified:
>>   cfe/trunk/lib/CodeGen/CGObjCMac.cpp
>> 
>> Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=108749&r1=108748&r2=108749&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Mon Jul 19 15:54:43 2010
>> @@ -3254,7 +3254,7 @@
>>    Entry = CreateMetadataVar("\01L_OBJC_CLASS_NAME_",
>>                          llvm::ConstantArray::get(VMContext,
>>                                                   Ident->getNameStart()),
>> -                              "__TEXT,__cstring,cstring_literals",
>> +                              "__TEXT,__objc_classname,cstring_literals",
>>                              1, true);
>> 
>>  return getConstantGEP(VMContext, Entry, 0, 0);
>> @@ -3638,7 +3638,7 @@
>>  if (!Entry)
>>    Entry = CreateMetadataVar("\01L_OBJC_METH_VAR_NAME_",
>>                        llvm::ConstantArray::get(VMContext, Sel.getAsString()),
>> -                              "__TEXT,__cstring,cstring_literals",
>> +                              "__TEXT,__objc_methname,cstring_literals",
>>                              1, true);
>> 
>>  return getConstantGEP(VMContext, Entry, 0, 0);
>> @@ -3663,7 +3663,7 @@
>>  if (!Entry)
>>    Entry = CreateMetadataVar("\01L_OBJC_METH_VAR_TYPE_",
>>                              llvm::ConstantArray::get(VMContext, TypeStr),
>> -                              "__TEXT,__cstring,cstring_literals",
>> +                              "__TEXT,__objc_methtype,cstring_literals",
>>                              1, true);
>> 
>>  return getConstantGEP(VMContext, Entry, 0, 0);
>> @@ -3679,7 +3679,7 @@
>>  if (!Entry)
>>    Entry = CreateMetadataVar("\01L_OBJC_METH_VAR_TYPE_",
>>                              llvm::ConstantArray::get(VMContext, TypeStr),
>> -                              "__TEXT,__cstring,cstring_literals",
>> +                              "__TEXT,__objc_methtype,cstring_literals",
>>                              1, true);
>> 
>>  return getConstantGEP(VMContext, Entry, 0, 0);
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 





More information about the cfe-commits mailing list