[cfe-commits] [patch] Implement support for @file

Daniel Dunbar daniel at zuster.org
Sun Jul 18 19:45:27 PDT 2010


LGTM.

 - Daniel

On Sun, Jul 18, 2010 at 5:56 PM, Rafael Espindola <espindola at google.com> wrote:
> On 18 July 2010 17:09, Daniel Dunbar <daniel at zuster.org> wrote:
>> Hi Rafael,
>>
>> I would just move the SavedStrings and StringPointers arguments that
>> get used when CCC_ADD_ARGS or QA_OVERRIDE_GCC3_OPTIONS is set to
>> always being used. That would simplify that code so that there is only
>> one call to BuildCompilation, and then you can use SavedStrings to
>> capture the memory used in @file args.
>
> Thanks, I did the basic refactoring and an updated patch is attached.
>
>>  - Daniel
>
> Cheers,
> --
> Rafael Ávila de Espíndola
>




More information about the cfe-commits mailing list