[cfe-commits] r108464 - /cfe/trunk/lib/CodeGen/Mangle.cpp

[John McCall]

Author: rjmccall
Date: Thu Jul 15 16:53:03 2010
New Revision: 108464

URL: http://llvm.org/viewvc/llvm-project?rev=108464&view=rev
Log:
After some discussion, the ABI list settled on a much more sensible mangling
for string literals.


Modified:
    cfe/trunk/lib/CodeGen/Mangle.cpp

Modified: cfe/trunk/lib/CodeGen/Mangle.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/Mangle.cpp?rev=108464&r1=108463&r2=108464&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/Mangle.cpp (original)
+++ cfe/trunk/lib/CodeGen/Mangle.cpp Thu Jul 15 16:53:03 2010
@@ -1974,13 +1974,10 @@
   }
 
   case Expr::StringLiteralClass: {
-    // Proposal from David Vandervoorde, 2010.06.30.
-    // I've sent a comment off asking whether this needs to also
-    // represent the length of the string.
+    // Revised proposal from David Vandervoorde, 2010.07.15.
     Out << 'L';
-    const ConstantArrayType *T = cast<ConstantArrayType>(E->getType());
-    QualType CharTy = T->getElementType().getUnqualifiedType();
-    mangleType(CharTy);
+    assert(isa<ConstantArrayType>(E->getType()));
+    mangleType(E->getType());
     Out << 'E';
     break;
   }