[cfe-commits] r108026 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/CodeGenCXX/instantiate-blocks.cpp

[Fariborz Jahanian]

On Jul 9, 2010, at 7:12 PM, Douglas Gregor wrote:

>
>
> Sent from my iPhone
>
> On Jul 9, 2010, at 3:21 PM, Fariborz Jahanian <fjahanian at apple.com>  
> wrote:
>
>> Author: fjahanian
>> Date: Fri Jul  9 17:21:32 2010
>> New Revision: 108026
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=108026&view=rev
>> Log:
>> BlockDeclRefExpr of a dependent type must
>> be a dependent expression when its is built.
>>
>>
>> Modified:
>>   cfe/trunk/lib/Sema/SemaExpr.cpp
>>   cfe/trunk/test/CodeGenCXX/instantiate-blocks.cpp
>>
>> Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=108026&r1=108025&r2=108026&view=diff
>>
>> +      else if (T->isDependentType())
>> +        BDRE->setTypeDependent(true);
>
> Since we only need to look at the declaration's type to determine  
> whether the BlockDeclRefExpr is type-dependent, why not move this  
> part of the computation into its constructor?

Done in r108157.

- Fariborz

>
>
>  - Doug
>
>>