[cfe-commits] r107953 - /cfe/trunk/lib/Basic/Targets.cpp

[John Thompson]

Looking at it in the debugger, validateOutputConstraint and
validateInputConstraint are also called earlier from Sema::ActOnAsmStmt
after parsing.  It seems you are implying that the string literals should be
modified at some point before the validate and other functions are called
that use the strings.

If so, can you tell me how to do it?  It seems that the expressions and so
forth are meant to be immutable after being created.

Otherwise, can you hold my hand a bit?  As I'm not sure what to do.

-John


On Fri, Jul 9, 2010 at 11:43 AM, Eli Friedman <eli.friedman at gmail.com>wrote:

> On Fri, Jul 9, 2010 at 11:27 AM, John Thompson
> <john.thompson.jtsoftware at gmail.com> wrote:
> >> As a first
> > approximation, we could just chop off everything after the first comma
> > (which would be enough to work for PR7338).
> > Do you mean something like the enclosed patch?
> >
> > If so, may I check it in?
>
> No, the check in question needs to happen in
> CodeGenFunction::EmitAsmStmt, before we call validateOutputConstraint
> or validateInputConstraint, or you won't end up with a valid asm in
> the IR.
>
> -Eli
>



-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100709/06a7d0f0/attachment.html>