[cfe-commits] r107706 - in /cfe/trunk: include/clang/AST/Stmt.h include/clang/Checker/PathSensitive/SVals.h include/clang/Driver/CC1Options.td include/clang/Frontend/AnalyzerOptions.h lib/AST/Stmt.cpp lib/Checker/AnalysisConsumer.cpp lib/Checker/

Tom Care tcare at apple.com
Tue Jul 6 18:09:30 PDT 2010

On Jul 6, 2010, at 5:39 PM, Chandler Carruth wrote:
> Any reason not to just 'continue' in the case below? At the very least 'break' there seems strange, llvm_unreachable would make more sense.

Originally it was there to silence the 'unhandled case' warning since I did not want to use a default. However after your comment I think that llvm_unreachable is more appropriate. I'll fix it up.
> Also, I tweaked this code a bit in r107741 and 107745 to make GCC happier about the msg variable. Check and see if that looks OK?
All good, thanks.


More information about the cfe-commits mailing list