[cfe-commits] r107305 - /cfe/trunk/lib/Sema/SemaOverload.cpp

[Eric Christopher]

On Jun 30, 2010, at 12:12 PM, Chandler Carruth wrote:

> On Wed, Jun 30, 2010 at 11:42 AM, Sebastian Redl <sebastian.redl at getdesigned.at> wrote:
> On 06/30/2010 08:36 PM, Eric Christopher wrote:
> > Author: echristo
> > Date: Wed Jun 30 13:36:32 2010
> > New Revision: 107305
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=107305&view=rev
> > Log:
> > Add a return to silence a warning.  Alternately a default: return false
> > would work.
> >
> > Sebastian: figure out which one you want :)
> >
> GCC is confused; the switch is complete on OverloadResult, so what we
> really want is an llvm_unreachable. (Is that used in Clang?)
> 
> It is, and is a better than return IMO.

Sure, I just wanted the warning to shush :)

I agree that an unreachable is great if the switch is complete.

-eric