[cfe-commits] r106617 - /cfe/trunk/lib/Checker/OSAtomicChecker.cpp

[Zhongxing Xu]

Author: zhongxingxu
Date: Tue Jun 22 21:12:00 2010
New Revision: 106617

URL: http://llvm.org/viewvc/llvm-project?rev=106617&view=rev
Log:
add comments.

Modified:
    cfe/trunk/lib/Checker/OSAtomicChecker.cpp

Modified: cfe/trunk/lib/Checker/OSAtomicChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Checker/OSAtomicChecker.cpp?rev=106617&r1=106616&r2=106617&view=diff
==============================================================================
--- cfe/trunk/lib/Checker/OSAtomicChecker.cpp (original)
+++ cfe/trunk/lib/Checker/OSAtomicChecker.cpp Tue Jun 22 21:12:00 2010
@@ -102,7 +102,11 @@
   SVal location = state->getSVal(theValueExpr);
   // Here we should use the value type of the region as the load type, because
   // we are simulating the semantics of the function, not the semantics of 
-  // passing argument.
+  // passing argument. So the type of theValue expr is not we are loading.
+  // But usually the type of the varregion is not the type we want either,
+  // we still need to do a CastRetrievedVal in store manager. So actually this
+  // LoadTy specifying can be omitted. But we put it here to emphasize the 
+  // semantics.
   QualType LoadTy;
   if (const TypedRegion *TR =
       dyn_cast_or_null<TypedRegion>(location.getAsRegion())) {